New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODataUriParser should allow duplicate non-OData query options #245

Closed
brjohnstmsft opened this Issue Jun 19, 2015 · 1 comment

Comments

Projects
None yet
6 participants
@brjohnstmsft
Contributor

brjohnstmsft commented Jun 19, 2015

Our Web API exposes both OData and custom query options. Some of our query options allow duplicate values, but ODataUriParser throws an exception when it detects any duplicate query options (not just standard OData query options). This requires us to maintain a lot of code to work around this issue that we would rather not have to maintain.

ODataLib should have no opinions on whether it is valid to have duplicate custom query options. A Dictionary should only be used to hold OData query options, not custom query options (see ODataUriParser.InitQueryOptionDic).

@congysu congysu added this to the 6.14 milestone Aug 7, 2015

@LianwMS LianwMS modified the milestones: 6.14, 6.15 Dec 21, 2015

@LianwMS LianwMS modified the milestones: 6.15, 6.14 Dec 21, 2015

@LaylaLiu LaylaLiu self-assigned this Mar 18, 2016

@LaylaLiu LaylaLiu modified the milestone: 6.15 Mar 18, 2016

@LaylaLiu LaylaLiu assigned TomDu and unassigned LaylaLiu Mar 21, 2016

@LaylaLiu LaylaLiu added this to the 7.0 milestone Mar 25, 2016

TomDu added a commit to TomDu/odata.net that referenced this issue Apr 28, 2016

@TomDu

This comment has been minimized.

Contributor

TomDu commented Apr 28, 2016

Non-OData query options are now exposed as a key-value list in CustomODataQueryOptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment