Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-In Functions to be customized #378

Closed
YogiBear52 opened this issue Nov 15, 2015 · 2 comments

Comments

Projects
None yet
5 participants
@YogiBear52
Copy link

commented Nov 15, 2015

OData.Core has Built-In Functions like 'contains' 'endswith' 'geo.intersects' and so on. These functions are hard coded and cannot be customized or be modify.

OData lib has to be open and easy to be customized and modified by the users needs.

I suggest to add Custom Functions mechanism so the user could add,modify or override the existing pre defined built-in functions.

@congysu congysu added this to the 6.15 milestone Nov 17, 2015

YogiBear52 pushed a commit to YogiBear52/odata.net that referenced this issue Dec 22, 2015

YogiBear52
Built-In Functions to be customized OData#378
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.

YogiBear52 pushed a commit to YogiBear52/odata.net that referenced this issue Jan 8, 2016

YogiBear52
Fixes to LaylaLiu, Issue OData#378 OData#430
- Usage of 'ExceptionUtils'
- Typo fixes
- lock 'TryGetCustomFunction' method

LaylaLiu added a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016

Built-In Functions to be customized OData#378
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.

LaylaLiu added a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016

Fixes to LaylaLiu, Issue OData#378 OData#430
- Usage of 'ExceptionUtils'
- Typo fixes
- lock 'TryGetCustomFunction' method

LaylaLiu added a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016

Built-In Functions to be customized OData#378
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.
* Changed name of some methods :
'MatchSignatureToBuiltInFunction' to 'MatchSignatureToUriFunction'.
'BindAsBuiltInFunction' to 'BindAsUriFunction'.

LaylaLiu added a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016

Built-In Functions to be customized OData#378
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.
* Changed name of some methods :
'MatchSignatureToBuiltInFunction' to 'MatchSignatureToUriFunction'.
'BindAsBuiltInFunction' to 'BindAsUriFunction'.

LaylaLiu added a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016

Built-In Functions to be customized OData#378
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.
* Changed name of some methods :
'MatchSignatureToBuiltInFunction' to 'MatchSignatureToUriFunction'.
'BindAsBuiltInFunction' to 'BindAsUriFunction'.

@LaylaLiu LaylaLiu added docs and removed 0 - Cost estimating labels Mar 18, 2016

@LaylaLiu LaylaLiu modified the milestone: 6.15 Mar 18, 2016

@brjohnstmsft

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2016

@LaylaLiu @YogiBear52 Why aren't custom functions determined based on the EDM model? Having a global table of functions is unfortunate since in some OData services, there are multiple models in the same AppDomain and not all of them have the same set of custom functions. The global table breaks the isolation between EDM models.

@AlanWong-MS

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2017

Per comment in #430, this issue has been resolved. Closing issue, but please feel free to continue the discussion here for any questions.

@AlanWong-MS AlanWong-MS closed this Jun 6, 2017

@LaylaLiu LaylaLiu removed the docs label Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.