New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"1997-02-04" in url will be deserialized as datatimeoffset constant query node #508

Closed
LianwMS opened this Issue Mar 18, 2016 · 0 comments

Comments

Projects
None yet
5 participants
@LianwMS
Contributor

LianwMS commented Mar 18, 2016

In ABNF:
dateTimeOffsetValue = year "-" month "-" day "T" hour ":" minute [ ":" second [ "." fractionalSeconds ] ]("Z" / sign hour ":" minute)
dateValue = year "-" month "-" day

1997-02-04 should deserialized as date constant query node after url parser. but now, sometimes it is datetiemoffset constant query node.

Assemblies affected

OData .Net lib

Reproduce steps

Cases:
FilterWithShortDatetimeOffset
FilterWithDate

Expected result

date constant query node

Actual result

datetiemoffset constant query node.

Additional details

During the developing of date/time, we do some promotion (TypePromotionUtils) in code if need to avoid breaking change.

@LianwMS LianwMS added this to the 7.0 milestone Mar 18, 2016

@LianwMS LianwMS changed the title from "1997-02-04" in url will be deserialized as datatimeoffset constant query node to "1997-02-04" in url will be deserialized as datatimeoffset constant query node Mar 18, 2016

@LianwMS LianwMS added the breaking label Mar 18, 2016

@LaylaLiu LaylaLiu added the ready label Mar 18, 2016

@markdstafford markdstafford removed the breaking label Jun 20, 2016

@LaylaLiu LaylaLiu added 1 - Backlog and removed ready labels Jun 24, 2016

@LianwMS LianwMS added docs breaking and removed ready labels Jul 19, 2016

@manivannanse manivannanse added the P3 label Jun 8, 2017

@mikepizzo mikepizzo added the not-fixed label Jul 31, 2017

@mikepizzo mikepizzo closed this Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment