New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize validation in reader and writer #517

Closed
Zoe-ms opened this Issue Mar 28, 2016 · 1 comment

Comments

Projects
None yet
5 participants
@Zoe-ms
Contributor

Zoe-ms commented Mar 28, 2016

We have kinds of validations, like duplicationnamechecker, collectionvalidator, WriterValidationUtils, ReaderValidationUtils, ValidationUtils which are all used through the process of Reader and Writer. Better centralize all validations, so they can be easily turn on and off, also for easier maintenance.

@Zoe-ms

This comment has been minimized.

Contributor

Zoe-ms commented Mar 28, 2016

This commits 32860ca done partially

@Zoe-ms Zoe-ms added this to the 7.0 milestone Mar 28, 2016

@LaylaLiu LaylaLiu added the ready label Apr 1, 2016

@Zoe-ms Zoe-ms changed the title from [Code Quality] Centralize validation in reader and writer to Centralize validation in reader and writer May 6, 2016

@Zoe-ms Zoe-ms added the breaking label May 6, 2016

@Zoe-ms Zoe-ms added in-progress and removed ready labels May 23, 2016

Lingxi-Li added a commit that referenced this issue May 27, 2016

Merge pull request #583 from Lingxi-Li/bak
Refactor writer validation setting interface (relates to #517)

@LaylaLiu LaylaLiu added docs and removed in-progress labels Jul 19, 2016

@manivannanse manivannanse added the P4 label Jun 8, 2017

@mikepizzo mikepizzo added the not-fixed label Jul 31, 2017

@mikepizzo mikepizzo closed this Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment