New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uri in IEdmReference is a string type #551

Closed
Zoe-ms opened this Issue Apr 28, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@Zoe-ms
Contributor

Zoe-ms commented Apr 28, 2016

The value of the Uri attribute in edmx:Reference SHOULD be a URL.

And we have suppression:
// Already public APIs thus cannot be changed.
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1056:UriPropertiesShouldNotBeStrings", Scope = "member", Target = "Microsoft.OData.Edm.IEdmReference.#Uri")]

So consider change string type to System.Uri

@Zoe-ms Zoe-ms added the breaking label Apr 28, 2016

@Zoe-ms Zoe-ms added this to the 7.0 milestone Apr 28, 2016

@LaylaLiu LaylaLiu added the ready label Apr 29, 2016

@TomDu TomDu self-assigned this May 12, 2016

TomDu added a commit to TomDu/odata.net that referenced this issue May 13, 2016

TomDu added a commit to TomDu/odata.net that referenced this issue May 13, 2016

@TomDu TomDu added docs and removed reviewing labels May 13, 2016

@TomDu TomDu closed this Aug 1, 2016

@TomDu TomDu removed the docs label Aug 1, 2016

TomDu added a commit that referenced this issue Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment