New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether ODataAnnotable can be removed if the annotated classes are not relevent #614

Closed
lewischeng-ms opened this Issue Jun 29, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@lewischeng-ms
Contributor

lewischeng-ms commented Jun 29, 2016

No description provided.

@lewischeng-ms lewischeng-ms added this to the 7.0 milestone Jun 29, 2016

@lewischeng-ms lewischeng-ms self-assigned this Jun 29, 2016

@lewischeng-ms

This comment has been minimized.

Contributor

lewischeng-ms commented Jul 5, 2016

Part 1: ODataAnnotatable can be safely removed from the URI parser part in the production code. Also checked that Web API doens't store or retrieve any annotation for the URI parsing. If there is no real need for URI parser elements being annotatable, we shall remove that first.

@lewischeng-ms

This comment has been minimized.

Contributor

lewischeng-ms commented Jul 19, 2016

Part 2: Remove all occurrences in product code (except client) that use SetAnnotation<T>() and GetAnnotation<T>(). Then remove those two methods from ODataAnnotatable.

@lewischeng-ms

This comment has been minimized.

Contributor

lewischeng-ms commented Jul 19, 2016

Part 3: Introduce a temporary replacement of the original ODataAnnotatable in client. We will refactor/redesign it later if there is performance bottleneck. Related issue #641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment