New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support writing enum-valued Annotations #814

Closed
mikepizzo opened this Issue May 24, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@mikepizzo
Member

mikepizzo commented May 24, 2017

ODataLib doesn't support writing annotations whose value is an enum.

Assemblies affected

OData .Net lib 6.x, OData.NET lib 7.x.

Reproduce steps

ODataProperty property = new ODataProperty { Name="Name", Value="Dan"};
property.InstanceAnnotations.Add(new ODataInstanceAnnotation(CoreVocabularyModel.PermissionsTerm.FullName(), new ODataEnumValue("Read", "Org.OData.Core.V1.Permission")));

Expected result

Annotation should be written:

{
    "Name":"Dan",
    "Name@Org.OData.Core.V1.Permissions": "Read"
}

Actual result

Exception is thrown.

mikepizzo added a commit that referenced this issue May 24, 2017

xuzhg added a commit that referenced this issue May 26, 2017

@manivannanse manivannanse added the P2 label May 31, 2017

mikepizzo added a commit to mikepizzo/odata.net that referenced this issue Jun 27, 2017

Support Reading/Writing Optional Parameters
Support selecting best function overload based on optional parameters

Update tests, validation.
Support annotating ReturnType (and ignore unexpected annotations elsewhere)

Added files to legacy projects and fixing CA issues.

Fix Issue OData#814

Added files to legacy projects and fixing CA issues.

Fix test issues

Fix tests and CA issues

Fix legacy project files

Fix stupid project issues.

Fix stupid project issues.

Fixing so build works on .Net35.
Clean up code and added more test cases

Fix tests

More test fixes.

Final core vocab test fixes.

mikepizzo added a commit to mikepizzo/odata.net that referenced this issue Jun 27, 2017

Support Reading/Writing Optional Parameters
Support selecting best function overload based on optional parameters

Update tests, validation.
Support annotating ReturnType (and ignore unexpected annotations elsewhere)

Added files to legacy projects and fixing CA issues.

Fix Issue OData#814

Added files to legacy projects and fixing CA issues.

Fix test issues

Fix tests and CA issues

Fix legacy project files

Fix stupid project issues.

Fix stupid project issues.

Fixing so build works on .Net35.
Clean up code and added more test cases

Fix tests

More test fixes.

Final core vocab test fixes.
@xuzhg

This comment has been minimized.

Member

xuzhg commented Jan 10, 2018

Fix at #815. Thanks!

mikepizzo added a commit that referenced this issue May 21, 2018

Entity set aggregations (#757)
* Support Reading/Writing Optional Parameters
Support selecting best function overload based on optional parameters

* Update tests, validation.
Support annotating ReturnType (and ignore unexpected annotations elsewhere)

* Fix Issue #814

* Added files to legacy projects and fixing CA issues.

* Added files to legacy projects and fixing CA issues.

* Fix test issues

* Fix tests and CA issues

* Fix legacy project files

* Fix stupid project issues.

* Fix stupid project issues.

* Fixing so build works on .Net35.

* Adding support to entity set aggregations.

* Support Reading/Writing Optional Parameters
Support selecting best function overload based on optional parameters

* Update tests, validation.
Support annotating ReturnType (and ignore unexpected annotations elsewhere)

* Added files to legacy projects and fixing CA issues.

* Added files to legacy projects and fixing CA issues.

* Fix legacy project files

* Fix stupid project issues.

* Fix stupid project issues.

* Adding support to entity set aggregations.

* Ensure that WebAPI aren't broken

* Rename PropertyAggregateExpression back to AggregateExpression

* Keep old aggregate token names

* Test to prove that entityset aggregations and functions without prefix can work together

* Ensure that we not using exception for control flow

* Extra tests for ApplyBinder

* Cleaning up code

* Minnor fixes (spaces, assert etc.)

* Rename files to reflect class names.

* Fix documentation tags

* Avoiud breaking changes and mark old properties obsolete

* Support Entity Set aggregation into ApplyClauseToStringBuilder

* More comment updates

biaol-odata added a commit to biaol-odata/odata.net that referenced this issue Jun 26, 2018

Entity set aggregations (OData#757)
* Support Reading/Writing Optional Parameters
Support selecting best function overload based on optional parameters

* Update tests, validation.
Support annotating ReturnType (and ignore unexpected annotations elsewhere)

* Fix Issue OData#814

* Added files to legacy projects and fixing CA issues.

* Added files to legacy projects and fixing CA issues.

* Fix test issues

* Fix tests and CA issues

* Fix legacy project files

* Fix stupid project issues.

* Fix stupid project issues.

* Fixing so build works on .Net35.

* Adding support to entity set aggregations.

* Support Reading/Writing Optional Parameters
Support selecting best function overload based on optional parameters

* Update tests, validation.
Support annotating ReturnType (and ignore unexpected annotations elsewhere)

* Added files to legacy projects and fixing CA issues.

* Added files to legacy projects and fixing CA issues.

* Fix legacy project files

* Fix stupid project issues.

* Fix stupid project issues.

* Adding support to entity set aggregations.

* Ensure that WebAPI aren't broken

* Rename PropertyAggregateExpression back to AggregateExpression

* Keep old aggregate token names

* Test to prove that entityset aggregations and functions without prefix can work together

* Ensure that we not using exception for control flow

* Extra tests for ApplyBinder

* Cleaning up code

* Minnor fixes (spaces, assert etc.)

* Rename files to reflect class names.

* Fix documentation tags

* Avoiud breaking changes and mark old properties obsolete

* Support Entity Set aggregation into ApplyClauseToStringBuilder

* More comment updates

biaol-odata added a commit that referenced this issue Jun 26, 2018

Entity set aggregations (#757)
* Support Reading/Writing Optional Parameters
Support selecting best function overload based on optional parameters

* Update tests, validation.
Support annotating ReturnType (and ignore unexpected annotations elsewhere)

* Fix Issue #814

* Added files to legacy projects and fixing CA issues.

* Added files to legacy projects and fixing CA issues.

* Fix test issues

* Fix tests and CA issues

* Fix legacy project files

* Fix stupid project issues.

* Fix stupid project issues.

* Fixing so build works on .Net35.

* Adding support to entity set aggregations.

* Support Reading/Writing Optional Parameters
Support selecting best function overload based on optional parameters

* Update tests, validation.
Support annotating ReturnType (and ignore unexpected annotations elsewhere)

* Added files to legacy projects and fixing CA issues.

* Added files to legacy projects and fixing CA issues.

* Fix legacy project files

* Fix stupid project issues.

* Fix stupid project issues.

* Adding support to entity set aggregations.

* Ensure that WebAPI aren't broken

* Rename PropertyAggregateExpression back to AggregateExpression

* Keep old aggregate token names

* Test to prove that entityset aggregations and functions without prefix can work together

* Ensure that we not using exception for control flow

* Extra tests for ApplyBinder

* Cleaning up code

* Minnor fixes (spaces, assert etc.)

* Rename files to reflect class names.

* Fix documentation tags

* Avoiud breaking changes and mark old properties obsolete

* Support Entity Set aggregation into ApplyClauseToStringBuilder

* More comment updates
@xuzhg

This comment has been minimized.

Member

xuzhg commented Oct 24, 2018

Close it.

@xuzhg xuzhg closed this Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment