Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add KeyAsSegmentSupported annotation term to Capabiliites vocabulary #1056
See issue at: https://issues.oasis-open.org/browse/ODATA-1134
In OData 4.01 we introduced semantics around supporting the popular key-as-segment URL syntax, but we have no generic way for clients to know whether or not the service supports this sytnax.
This PR is to add a new boolean term to the capabilities vocabulary,
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
CapabilitiesVocabularyModel.cs only defines IEdmTerms for ChangeTrackingTerm (where-as CoreVocabularyModel.cs defines IEdmTerms for most/all of the terms defined in the vocabulary). Should we define a term for KeyAsSegmentTerm (and the other capabilities terms) or do we not think there is value in defining these IEdmTerms? #Closed
Actually, we don't need to do that, because:
That's fine with me; I just wanted to be sure we had a good reason for the difference.
It appears that we do use ChangeTrackingTerm from the capabilities vocabulary, and presumably get a performance improvement for having it a static value and not having to look it up each time we use it.
Maybe consider adding a code comment to CapabilitiesVocabularyModel.cs calling out why we define an IEdmTerm for Changetracking but intentionally don't define IEdmTerm values for the other terms.
In reply to: 361427705 (ancestors = 361427705)