Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Include dots in parseIdentifier for annotation parsing #1123
This pull request fixes an issue for annotation parsing in ODL 7.4.2.
Annotation such as "@NS.myAnnotation" are not parsed correctly as Identifier token because lexer stops at the dot char during the traversing. This can be fixed by allowing to include dot chars for paring string token starting with "@", which could be either an parameter alias (w/o dots) or an annotation.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
Can we add some additional tests for the UriParser, to parse different expressions containing combinations of annotations and parameter markers? i.e.; with this change, the lexer will support the parser parsing @my.annotation eq 5 in a filter expression; that should either throw a reasonable exception or parse to an annotation node as the left operand; it should not successfully parse as a parameter as the left operand. #Resolved