New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringComparison in String.Equal() method call #1130

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@xuzhg
Member

xuzhg commented Mar 23, 2018

Issues

Description

  • Add StringComparison in String.Equal() method call.*

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

@xuzhg xuzhg requested review from mikepizzo, AlanWong-MS and biaol-odata Mar 24, 2018

@biaol-odata

This comment has been minimized.

Member

biaol-odata commented Mar 24, 2018

@xuzhg We should make sure the suppresions for CA1307 such as the following are cleaned up as well:
test\EndToEndTests\Framework\Reliability\GlobalSuppressions.cs Line8:
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Globalization", "CA1307:SpecifyStringComparison"......

@xuzhg

This comment has been minimized.

Member

xuzhg commented Mar 25, 2018

@biaol-odata Thanks your information. Do you know what's the usage of "Reliability"? And I saw all the 'CA1307' are not related to String.Equals.

@mikepizzo

Thanks Sam. I'm less concerned about updating test cases than production code, but great that you covered both.

@xuzhg xuzhg merged commit 4a0bfdc into OData:master Mar 26, 2018

2 checks passed

continuous-integration/vsts The build trigger has fired.
Details
license/cla All CLA requirements met.
Details
@biaol-odata

This comment has been minimized.

Member

biaol-odata commented Mar 26, 2018

@xuzhg I am not sure what the usage of "Reliability" is. I was just thinking it would be logical to remove the CA1307, which is either no further changes required or leading us to more finding. Since this has been merged already, no further action is required now (good item to work on for next MQ?).

@biaol-odata biaol-odata referenced this pull request Jun 26, 2018

Merged

Release v7.5.0 #1201

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment