Add support for ENUM keys #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhaarathms Would you please help add test cases related to your change? |
|
@xuzhg Added tests covering all the changes made in this PR |
xuzhg
requested changes
Oct 4, 2017
| @@ -186,6 +186,15 @@ public void GetOrCreateEdmTypeShouldThrowIfTypeHasObjectProperty() | |||
| test.ShouldThrow<InvalidOperationException>().WithMessage(Strings.ClientType_NoSettableFields("System.Object")); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void GetOrCreateEdmTypeShouldShouldWorkForEnumTypes() | |||
There was a problem hiding this comment.
@xuzhg fixed it
xuzhg
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Do not know if there is an issue open for this.
Description
Currently only simple keys are supported. Adding ability to support Enum keys.
Checklist (Uncheck if it is not completed)
Additional work necessary
No