New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ENUM keys #961

Merged
merged 4 commits into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@bhaarathms
Contributor

bhaarathms commented Sep 27, 2017

Issues

Do not know if there is an issue open for this.

Description

Currently only simple keys are supported. Adding ability to support Enum keys.

Checklist (Uncheck if it is not completed)

  • [ X ] Test cases added
  • [ ] Build and test with one-click build and test script passed

Additional work necessary

No

bhaarathms added some commits Sep 27, 2017

@xuzhg xuzhg self-assigned this Oct 3, 2017

@xuzhg

This comment has been minimized.

Member

xuzhg commented Oct 3, 2017

@bhaarathms Would you please help add test cases related to your change?

@bhaarathms

This comment has been minimized.

Contributor

bhaarathms commented Oct 4, 2017

@xuzhg Added tests covering all the changes made in this PR

@@ -186,6 +186,15 @@ public void GetOrCreateEdmTypeShouldThrowIfTypeHasObjectProperty()
test.ShouldThrow<InvalidOperationException>().WithMessage(Strings.ClientType_NoSettableFields("System.Object"));
}
[TestMethod]
public void GetOrCreateEdmTypeShouldShouldWorkForEnumTypes()

This comment has been minimized.

@xuzhg

xuzhg Oct 4, 2017

Member

double "should"

This comment has been minimized.

@bhaarathms

bhaarathms Oct 4, 2017

Contributor

@xuzhg fixed it

@xuzhg

xuzhg approved these changes Oct 6, 2017

@manivannanse manivannanse merged commit 58e999d into OData:master Oct 10, 2017

2 checks passed

continuous-integration/vsts The build trigger has fired.
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment