Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize component naming #67

Closed
tobias-kuendig opened this issue Oct 1, 2018 · 5 comments
Closed

Optimize component naming #67

tobias-kuendig opened this issue Oct 1, 2018 · 5 comments
Milestone
1.0.0

Comments

@tobias-kuendig
Copy link
Member

New proposed names:

  • Category -> ProductList
  • Product -> ProductDetail
  • CategoryFilter -> ProductFilter
@tobias-kuendig tobias-kuendig added this to the 1.0.0 milestone Oct 1, 2018
@tobias-kuendig tobias-kuendig changed the title Optimize category naming Optimize component naming Oct 1, 2018
@amdad
Copy link
Contributor

amdad commented Oct 1, 2018

That's right! I'll do this simple changes. But.. promoted products are a little bit more complicated.

@tobias-kuendig
Copy link
Member Author

If you can do this and #40 together that would be great and prevent some nasty merge conflicts!

Leave promoted products for later.

@amdad
Copy link
Contributor

amdad commented Oct 1, 2018 •
edited

Alright, sorry for delay but server issues stole the night :)

@amdad
Copy link
Contributor

amdad commented Oct 2, 2018

I'm was about to change this, but I want to propose first this. Why not like this:

Category -> Products
Product -> Product (keep the name)
CategoryFilter -> ProductsFilter

Especially changing Product to ProductDetail I see as unnecessary complication. Or you have any real reason for that?
Products and Product, like Rainlab.Blog Posts and Post components. Simple as that.

I'm not sure about English here, but it seems both ProductFilter and ProductsFilter are correct. But in our case this one is tightly connect to Products component, works as it's extension. So to naming can reflect that. What do you think?

@tobias-kuendig
Copy link
Member Author

Good points, let's go with your suggestions 👍

@skobb skobb mentioned this issue Apr 22, 2019
Closed
@Mabudigital Mabudigital mentioned this issue May 20, 2019
Closed
@Patrick-foreseers Patrick-foreseers mentioned this issue Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@tobias-kuendig @amdad