From 9bbaf0c6a92c2e1737a9bd59d99168c02479ca1a Mon Sep 17 00:00:00 2001 From: Michael Adler Date: Mon, 17 Jun 2024 08:31:17 -0400 Subject: [PATCH] hssi: increate timeout to 1 second Some operations are taking longer than the current timeout, such as putting an HSSI port in loopback. Timeout is a failure, so waiting a little long isn't a problem. Actual completion observed has been over 100ms, so chose 1 second. The current timeout logic could be improved but is not changed in this commit. Time passed is calculated as the sum of sleep times, which assumes MMIO reads are free and sleep is exactly the requested wait. Signed-off-by: Michael Adler --- binaries/hssi/ethernet/hssicommon.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/binaries/hssi/ethernet/hssicommon.py b/binaries/hssi/ethernet/hssicommon.py index c792c084c7b8..d92d53713a8c 100644 --- a/binaries/hssi/ethernet/hssicommon.py +++ b/binaries/hssi/ethernet/hssicommon.py @@ -53,8 +53,10 @@ # mailbox register poll interval 1 microseconds HSSI_POLL_SLEEP_TIME = 1/1000000 -# mailbox register poll timeout 500 microseconds -HSSI_POLL_TIMEOUT = 5/10000 +# Mailbox register poll timeout 1 second. Responses are typically much +# faster than one second, but in rare cases can take a while. No reason +# to make this short since timeout is generally a failure. +HSSI_POLL_TIMEOUT = 1 HSSI_FEATURE_ID = 0x15