Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy_to_basedir #467

Closed
anoukvlug opened this Issue May 31, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@anoukvlug
Copy link
Contributor

anoukvlug commented May 31, 2018

@fmaussion, like we discussed during the oggm workshop, I would like to make a pull request for adding ''cesm_data'' to the options 'run' and 'inversion' of the copy_to_basedir function.

While playing around with this function, I didn't find an entity task that can be used to use this function. I just wrote one. Shall I add it to the pull request? Or is there already a more suitable way to use this function?

@fmaussion

This comment has been minimized.

Copy link
Member

fmaussion commented May 31, 2018

Hi Anouk, until now the copy_to_basedir is a method available from the gdir object. I never considered making an entity task out of it, although maybe it would make sense for paralelizing the copy/paste.

Yes, open a PR and we can discuss the details there

@fmaussion

This comment has been minimized.

Copy link
Member

fmaussion commented May 31, 2018

Just to claridfy: until now I did:

for gdir in gdirs:
    gdir.copy_to_basedir()

But maybe this could be done in parallel yes

@anoukvlug

This comment has been minimized.

Copy link
Contributor Author

anoukvlug commented May 31, 2018

It make a sense to do it like that. Somehow the first thing that came to my mind was making an entity task for it. Anyway I will make a pull request to discuss this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.