Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SH diagnostic files have wrong calendar date #824

Closed
fmaussion opened this issue Jul 12, 2019 · 0 comments

Comments

@fmaussion
Copy link
Member

commented Jul 12, 2019

Thanks @DavidParkes for the report.

The problem is here:

oggm/oggm/core/flowline.py

Lines 720 to 721 in 47b30c9

yrs, months = utils.floatyear_to_date(monthly_time)
cyrs, cmonths = utils.hydrodate_to_calendardate(yrs, months)

Here we should use start_month=4 for SH glaciers. The fix is not super straightforward though, because:

  • the FlowlineModel instance doesn't know if it's on the SH or not
  • I don't know yet what to do with the aggregated files

A way to go would be to ditch calendar dates altogether...

Note also that I'm not sure that ALL SH glaciers are using the April-March convention. Might be worth re-evaluating this decision at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.