Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fractional anomalies for precipitation timeseries #393

Merged
merged 7 commits into from Jan 19, 2018

Conversation

Projects
None yet
2 participants
@fmaussion
Copy link
Member

fmaussion commented Jan 12, 2018

No description provided.

fmaussion added some commits Jan 12, 2018

@fmaussion fmaussion changed the title Clip precip to make sure that we don't get negative values Possible change to CRU processing Jan 13, 2018

@fmaussion

This comment has been minimized.

Copy link
Member Author

fmaussion commented Jan 13, 2018

@anoukvlug you should consider using this code for your purposes from now on.

This change won't make it for version 1.0 of OGGM, but the CESM part could use this new default. Let's talk about the strategy to use offline in slack

@anoukvlug

This comment has been minimized.

Copy link
Contributor

anoukvlug commented Jan 16, 2018

Thanks for making these changes @fmaussion. Discussing it further on Slack sounds like a good plan.

@fmaussion fmaussion changed the title Possible change to CRU processing Use fractional anomalies for precipitation timeseries Jan 19, 2018

@fmaussion

This comment has been minimized.

Copy link
Member Author

fmaussion commented Jan 19, 2018

OK this should be ready. @anoukvlug can you have a look? Thanks!

@fmaussion fmaussion requested a review from anoukvlug Jan 19, 2018

~~~~~~~~

OGGM can also use climate model output to drive the mass-balance model. In
these case we still rely on gridded observations (CRU) for the baseline

This comment has been minimized.

Copy link
@anoukvlug

anoukvlug Jan 19, 2018

Contributor

"this case" instead of "these case"

@anoukvlug
Copy link
Contributor

anoukvlug left a comment

It looks good to me :) Thanks @fmaussion!

@fmaussion fmaussion merged commit 23ea60c into OGGM:master Jan 19, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 90.526%
Details
@fmaussion

This comment has been minimized.

Copy link
Member Author

fmaussion commented Jan 19, 2018

In it goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.