Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ref_tstars after PRCP update #407

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
1 participant
@fmaussion
Copy link
Member

fmaussion commented Jan 24, 2018

  • Closes #406
  • Tests added/passed

Relevant commit in sample data: OGGM/oggm-sample-data@17fe988

It appears that the changes in t* are not so large, mostly the biases are affected. The new bias in standard deviation is 87% (instead of 90% before), indicating that we should probably go for a larger precip correction factor

@fmaussion

This comment has been minimized.

Copy link
Member Author

fmaussion commented Jan 24, 2018

The remaining failing test is due to googlemap - will do in a separate PR

@fmaussion fmaussion merged commit 8a8e5c7 into OGGM:master Jan 24, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-2.07%) to 85.969%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.