Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ref_tstars after PRCP update #407

Merged
merged 1 commit into from Jan 24, 2018
Merged

Update ref_tstars after PRCP update #407

merged 1 commit into from Jan 24, 2018

Conversation

@fmaussion
Copy link
Member

@fmaussion fmaussion commented Jan 24, 2018

  • Closes #406
  • Tests added/passed

Relevant commit in sample data: OGGM/oggm-sample-data@17fe988

It appears that the changes in t* are not so large, mostly the biases are affected. The new bias in standard deviation is 87% (instead of 90% before), indicating that we should probably go for a larger precip correction factor

@fmaussion
Copy link
Member Author

@fmaussion fmaussion commented Jan 24, 2018

The remaining failing test is due to googlemap - will do in a separate PR

@fmaussion fmaussion merged commit 8a8e5c7 into OGGM:master Jan 24, 2018
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant