Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run from spinup option #411

Merged
merged 8 commits into from Feb 6, 2018
Merged

Add run from spinup option #411

merged 8 commits into from Feb 6, 2018

Conversation

@fmaussion
Copy link
Member

@fmaussion fmaussion commented Jan 31, 2018

  • Closes #394
  • Tests added/passed
  • Fully documented, including whats-new.rst for all changes
@fmaussion
Copy link
Member Author

@fmaussion fmaussion commented Jan 31, 2018

Still a WIP: this first commit simply refactors some functions

Loading

@fmaussion
Copy link
Member Author

@fmaussion fmaussion commented Feb 2, 2018

OK, this should be it. CC @anoukvlug for a review.

Note that once again this is not backwards compatible (keyword names have changed). Altogether this is for a good purpose, the calls are now much simpler. Furthermore, no new task was needed, which is also nice.

Loading

@fmaussion fmaussion changed the title WIP: add run from spinup task Add run from spinup option Feb 2, 2018
Copy link
Contributor

@anoukvlug anoukvlug left a comment

Thanks @fmaussion for making this nice addition! :D

Loading

bias=bias, seed=seed, filename=filename,
input_filesuffix=input_filesuffix)
bias=bias, seed=seed,
filename=climate_filename,
Copy link
Contributor

@anoukvlug anoukvlug Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just wondering, why do you keep the "filename" keyword and not also change it to "climate_filename"?

Loading

@fmaussion
Copy link
Member Author

@fmaussion fmaussion commented Feb 5, 2018

I am just wondering, why do you keep the "filename" keyword and not also change it to "climate_filename"?

That's a very good point! The actual reason is that it would mean even more changes -- and I didn't want to do it all at once without a clear strategy. Will open an issue for this

Loading

@fmaussion fmaussion merged commit 22b3935 into OGGM:master Feb 6, 2018
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants