Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Model optimisation #415

Merged
merged 2 commits into from Feb 12, 2018

Conversation

Projects
None yet
1 participant
@fmaussion
Copy link
Member

commented Feb 10, 2018

  • Tests added/passed
  • Fully documented, including whats-new.rst for all changes

This PR is a very straightforward optimization of the upstream 2D scheme: we simply avoid to compute the same things many times, in particular indexing. The results shouldn't be affected at all (if they are, this is a bug).

The code runs roughly twice as fast ;)

cc @alexjarosch @phigre

fmaussion added some commits Feb 10, 2018

@fmaussion fmaussion merged commit e7f2a75 into OGGM:master Feb 12, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.