Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some additions to copy files #468

Merged
merged 3 commits into from Jun 8, 2018

Conversation

Projects
None yet
2 participants
@anoukvlug
Copy link
Contributor

anoukvlug commented May 31, 2018

This pull request addresses issue #467.

  1. It adds copying cesm_data files to the option 'inversion' and 'run' of the copy_to_basedir function.
  2. It adds an entity task for copying files with the copy_to_basedir function.
@fmaussion

This comment has been minimized.

Copy link
Member

fmaussion commented Jun 1, 2018

Thanks a lot! Actually, I think that making an entity task out of it makes much sense.

Could you move the entire code to the task? I.e. the gdir.copy_to_basedir method should be deleted, and instead the task should contain all the code (this would be very similar code, but with gdir instead of self). This might brake some tests, so you'll have to adapt them too.

That would be great!

@anoukvlug

This comment has been minimized.

Copy link
Contributor Author

anoukvlug commented Jun 1, 2018

Yes, I just did. Thanks for the instructions! I will update my PR in a bit :)

@fmaussion

This comment has been minimized.

Copy link
Member

fmaussion commented Jun 8, 2018

This is excellent job, thanks! One last thing: can you add a short description of your change in whats-new.rst? It is a small but breaking change, so it should be documented in the "breaking change" section

@anoukvlug

This comment has been minimized.

Copy link
Contributor Author

anoukvlug commented Jun 8, 2018

Thanks :) Yes, I can add some documentation to whats-new.rst today .

I was wondering, when I click on the issues and pull requests on the whats-new.rst page these don't work as a link, is it supposed to be like that?

@fmaussion

This comment has been minimized.

Copy link
Member

fmaussion commented Jun 8, 2018

I was wondering, when I click on the issues and pull requests on the whats-new.rst page these don't work as a link, is it supposed to be like that?

Yes, they are rendered by sphinx when building the documentation. See: http://oggm.readthedocs.io/en/latest/whats-new.html

@anoukvlug

This comment has been minimized.

Copy link
Contributor Author

anoukvlug commented Jun 8, 2018

That makes a lot of sense :)

@fmaussion fmaussion merged commit 051d0aa into OGGM:master Jun 8, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@fmaussion

This comment has been minimized.

Copy link
Member

fmaussion commented Jun 8, 2018

Thanks!

@anoukvlug anoukvlug deleted the anoukvlug:copy-files-addition branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.