Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace colormaps with python-colorspace palettes #587
To close #548.
Currently a 'proof of concept' waiting on agreement that the palette choices are the best available in context. The
Therefore, I went for "Greens 2" for altitude (like grass, with white 'snow' at higher altitudes), "Blue-Yellow" (glacier-like colours) for section thickness & "Heat" for glacier thickness (red-based to make it clearly different to the blues of section thickness). Example images (compare to those in
Let me know your thoughts! There is no point adapting the documented & test baseline images until you are happy with the choices.
changed the title
Change colormaps to HCL-based python-colorspace palettes
Oct 31, 2018
Sorry it took me so long to get back to you. I hope you still have some time to spend on this! I like the new colors! Thanks a lot
My few comments:
Now to the colors:
As opposed to the one with "Greens" above. Maybe @retostauffer wants to chime in and let us know his suggestion for colors and topography ;)
Thanks for your detailed feedback @fmaussion!
No problem, I appreciate you fitting in time to look at this. I would like to finish this PR, though I am approaching a busier period now so I will dedicate some time this week to update it according to your feedback, but if I can't complete it so you are happy by then I will have to wait until mid-December to have another look. You can always take over this if you want to accelerate the change.
In hindsight, the terrain is certainly too subtle on my original proposal. I will revert the topography colormap. I will also invert the blue-yellow colormap as you suggest, & apply that same scheme for the glacier thickness plots. And of course implement the main requirement, to check if
Please feel free to comment further if you have any changes of mind for the colourmaps (or approach) still, as there are plenty to choose from & it is trivial to amend the selections. Otherwise I will update you when this PR is ready for re-review. Thanks again.
As well as the changes discussed above, I have upped the
Sample images (same examples as in my initial comment) with the new colour set choice specifications (the altitude colormap is now back to as in the main codebase, so the central image from my initial comment is identical to the original reference linked there):
The pale yellow hue for small section thickness isn't the most distinct against the white/grey of the background terrain image, but as long as this does not concern you I think these palette choices work well. If you prefer, however, I could crop the lower end of the color palette so that the scale zero is mapped to a slightly greener tinge?