New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new viewfinderpanorama DEM files #79

Merged
merged 2 commits into from May 11, 2016

Conversation

Projects
None yet
3 participants
@jlandmann
Contributor

jlandmann commented Apr 25, 2016

Not finished yet

j_landmann@gmx.de added some commits Apr 25, 2016

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 4, 2016

Coverage Status

Coverage decreased (-0.9%) to 89.519% when pulling c193a6b on JohannesUIBK:dem3 into 8e690d8 on OGGM:master.

coveralls commented May 4, 2016

Coverage Status

Coverage decreased (-0.9%) to 89.519% when pulling c193a6b on JohannesUIBK:dem3 into 8e690d8 on OGGM:master.

@fmaussion

This comment has been minimized.

Show comment
Hide comment
@fmaussion

fmaussion May 9, 2016

Member

@JohannesUIBK , is this last commit now taking care of what we discussed last time?

Member

fmaussion commented May 9, 2016

@JohannesUIBK , is this last commit now taking care of what we discussed last time?

@jlandmann

This comment has been minimized.

Show comment
Hide comment
@jlandmann

jlandmann May 10, 2016

Contributor

Indeed it is, I was just not able to test some things due to this GDAL/rasterio issue. But as I have seen now the dependcies should be fine, right? So maybe I can test this evening and then you can merge the PR! I will get back to you soon!

Contributor

jlandmann commented May 10, 2016

Indeed it is, I was just not able to test some things due to this GDAL/rasterio issue. But as I have seen now the dependcies should be fine, right? So maybe I can test this evening and then you can merge the PR! I will get back to you soon!

@jlandmann

This comment has been minimized.

Show comment
Hide comment
@jlandmann

jlandmann May 10, 2016

Contributor

Okay so I tried now to reinstall all Python packages from the conda forge channel, but I still cannot import rasterio properly somehow...consequently, I'm not really able to test if all the things work.
Does it work for you now?

Contributor

jlandmann commented May 10, 2016

Okay so I tried now to reinstall all Python packages from the conda forge channel, but I still cannot import rasterio properly somehow...consequently, I'm not really able to test if all the things work.
Does it work for you now?

@fmaussion

This comment has been minimized.

Show comment
Hide comment
@fmaussion

fmaussion May 10, 2016

Member

OK. If you can reproduce the problem easily in a fresh environment it might be worth to report it to conda-forge, but no hurry (windows sucks anyway ;-) ). On a side note: we have no such problems on appveyor, which is also using a windows machine.

I will have to clone your branch to test it, I will have a look by the end of the week. Thanks!

Member

fmaussion commented May 10, 2016

OK. If you can reproduce the problem easily in a fresh environment it might be worth to report it to conda-forge, but no hurry (windows sucks anyway ;-) ). On a side note: we have no such problems on appveyor, which is also using a windows machine.

I will have to clone your branch to test it, I will have a look by the end of the week. Thanks!

@fmaussion

This comment has been minimized.

Show comment
Hide comment
@fmaussion

fmaussion May 11, 2016

Member

OK, merging this now since tests are OK, will have a look at the details later today or tomorrow. Thanks @JohannesUIBK !

Member

fmaussion commented May 11, 2016

OK, merging this now since tests are OK, will have a look at the details later today or tomorrow. Thanks @JohannesUIBK !

@fmaussion fmaussion merged commit 6a761b5 into OGGM:master May 11, 2016

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.9%) to 89.519%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jlandmann

This comment has been minimized.

Show comment
Hide comment
@jlandmann

jlandmann May 12, 2016

Contributor

Okay and thanks for both the tip concerning the report and for the merge!

Contributor

jlandmann commented May 12, 2016

Okay and thanks for both the tip concerning the report and for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment