Enhancement related to TFRecords #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the docstring for |
cgohil8
reviewed
Mar 26, 2024
osl_dynamics/data/tf.py
Outdated
| @@ -142,6 +142,22 @@ def _make_example(sequence): | |||
| writer.write(_make_example(sequence)) | |||
|
|
|||
|
|
|||
| def _validate_tf_dataset(dataset): | |||
| """Check if the input is a valid TensorFlow dataset.""" | |||
There was a problem hiding this comment.
Would be good to add a 'Parameters' and 'Returns' section to this docstring
RukuangHuang
force-pushed
the
tfrecord_enhance
branch
from
396670f
to
02f5f2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows TFRecords/
tf.data.Datasetto be passed as inputs to several methods including:model.set_regularizersobs_mod.set_dev_parameters_initializerhmm.Model.dual_estimationdynemo.Model.dual_estimation