New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edge case where cmData raw cohort count and attrition "original population" count don't match #85

Closed

jamieweaver opened this issue Jul 12, 2019 · 1 comment

jamieweaver commented Jul 12, 2019

when using studyStartDate and studyEndDate in getDbCohortMethodData, the cohort start date must be <= study end date:
https://github.com/OHDSI/CohortMethod/blob/master/inst/sql/sql_server/CreateCohorts.sql#L226

but later when counting the original cohort sizes for the attrition table, the cohort start date must be < study end date:
https://github.com/OHDSI/CohortMethod/blob/master/inst/sql/sql_server/CountOverallExposedPopulation.sql#L80

adding <= the line 80 of CountOverallExposedPopulation.sql aligns the counts in the rare occurrences where this matters

Member

schuemie commented Jul 12, 2019

Thanks! Feel free to create a pull request (please target the develop branch).

jamieweaver mentioned this issue

fix where cmData raw cohort count and attrition "original cohort" size count don't match #86

Merged

schuemie closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment