visit_detail - some minor corrections - condition_occurrence and visit_type_concept_id#116
Merged
Conversation
Correction - visit_detail_concept_id should be just visit_concept_id; because in the same domain. Otherwise we will have to systematically rename all _concept_id fields in visit_detail into _detail_concept_id; e.g. visit_type_concept_id to visit_detail_type_concept_id admitting_source_concept_id to admitting_detail_source_concept_id makes it long and difficult in join statements etc
gowthamrao
changed the title
MaximMoinat
reviewed
Sep 26, 2017
| | provider_id | No | integer | A foreign key to the Provider in the PROVIDER table who was responsible for capturing (diagnosing) the Condition. | | ||
| | visit_occurrence_id | No | integer | A foreign key to the visit in the VISIT_OCCURRENCE table during which the Condition was determined (diagnosed). | visit_detail_id | No | integer | A foreign key to the visit in the VISIT_DETAIL table during which the Condition was determined (diagnosed). | | ||
| | visit_occurrence_id | No | integer | A foreign key to the visit in the VISIT_OCCURRENCE table during which the Condition was determined (diagnosed). | | ||
| | visit_detail_id | No | integer | A foreign key to the visit in the VISIT_DETAIL table during which the Condition was determined (diagnosed). | visit_detail_id | No | integer | A foreign key to the visit in the VISIT_DETAIL table during which the Condition was determined (diagnosed). | |
Collaborator
There was a problem hiding this comment.
It seems that the visit_detail_id row is duplicated on the same line. The table renders fine, but maybe still better to remove the duplicated information.
Contributor
There was a problem hiding this comment.
@MaximMoinat I thought so too but when I looked at the rendered version of the table there is only one line for visit_detail_id
Collaborator
|
Was about to make the same pull request, so thanks for creating this already. Could you also make those small fixes and update the pull request? Thanks in advance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.