Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in SQL "#case_in_period" should be "#cases_in_periods" #53

Closed
azimov opened this issue Mar 18, 2024 · 1 comment
Closed

Error in SQL "#case_in_period" should be "#cases_in_periods" #53

azimov opened this issue Mar 18, 2024 · 1 comment
Labels
bug Erroneous behavior that must be fixed

Comments

@azimov
Copy link
Contributor

azimov commented Mar 18, 2024

See attached error. errorReport 3.R.txt

Looking through the source code there are references to a table "#cases_in_periods" plural not "#cases_in_period" singular like in this error message on this line:

FROM #cases_in_period cases

SelfControlledCaseSeries/inst/sql/CreateCases.sql at a4a281a · OHDSI/SelfControlledCaseSeries
An R package for performing Self-Controlled Case Series (SCCS) analyses in an observational database in the OMOP Common Data Model. - OHDSI/SelfControlledCaseSeries
[11:40] Gilbert, James [JANUS]
The reference above is here:


SelfControlledCaseSeries/inst/sql/CreateCases.sql at a4a281a · OHDSI/SelfControlledCaseSeries
An R package for performing Self-Controlled Case Series (SCCS) analyses in an observational database in the OMOP Common Data Model. - OHDSI/SelfControlledCaseSeries

Not sure on steps to reproduce it but I have a PR incoming

@azimov azimov mentioned this issue Mar 18, 2024
@azimov
Copy link
Contributor Author

azimov commented Mar 19, 2024

To confirm the reproducibility of this bug - call getDbSccsData with a study start date and end date as well as nesting the cohort inside an indication cohort. The fix should allow this process to continue

@schuemie schuemie added the bug Erroneous behavior that must be fixed label May 22, 2024
@schuemie schuemie closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Erroneous behavior that must be fixed
Projects
None yet
Development

No branches or pull requests

2 participants