Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 2DMPR menu in the toolbar or MR study, when loaded images using standalone JSON format #1405

Closed
nagarjunaa opened this issue Jan 31, 2020 · 8 comments

Comments

@nagarjunaa
Copy link

Hi
I have loaded the images using http endpoint, Maping the data to our standalone JSON format in this case I miss the 2DMPR menu in the toolbar, for the same images in the ohif viewer I am getting it. whether I am missing any element or tag in the json. please guide me in this
my json format is
{
"transactionId": "BRAIN SELLA",
"studies": [
{
"studyInstanceUid": "1.2.840.113619.2.5.1762583153.215519.978957063.78",
"studyDescription": "BRAIN SELLA",
"studyDate": "20140720",
"studyTime": "120022",
"patientName": "Image1^Test",
"patientBirthDate": "",
"patientId": "93840",
"patientSex": "",
"seriesList": [
{
"seriesDescription": "SAG T-1",
"seriesInstanceUid": "1.2.840.113619.2.5.1762583153.215519.978957063.121",
"seriesBodyPart": "",
"seriesNumber": 2,
"seriesDate": null,
"seriesTime": null,
"seriesModality": "MR",
"instances": [
{
"columns": 13,
"rows": 13,
"instanceNumber": 1,
"acquisitionNumber": null,
"photometricInterpretation": null,
"sopInstanceUid": "1.2.840.113619.2.5.1762583153.215519.978957063.122",
"url": "dicomweb://fffffff.com/PACSImages/DRAbishek/20140720/1.2.840.113619.2.5.1762583153.215519.978957063.78/1.2.840.113619.2.5.1762583153.215519.978957063.121/1.2.840.113619.2.5.1762583153.215519.978957063.122.dcm"
}

@dannyrb
Copy link
Member

dannyrb commented Jan 31, 2020

See related response here, detailing the requirements for the MPR2D button to show:

#1385 (comment)

We have a separate goal of always showing the button, but detailing why MPR can't be used (missing fields, data set is not reconstructable, etc.)

@nagarjunaa
Copy link
Author

Hi Dannyrb,
I am not clear, could you please explain me better. I have gone through that link, what is the field I am missing.

@dannyrb
Copy link
Member

dannyrb commented Jan 31, 2020

Unfortunately, I don't have the bandwidth right now to compare each tag against your JSON. You need to look at each getRawValue and getTagValue call in this file:

https://github.com/OHIF/Viewers/blob/460e375f0aa75d35f7a46b4d48e6cc706019956d/platform/core/src/utils/isDisplaySetReconstructable.js

If you provide all of those tags, it's possible you don't meet a constraint of isDisplaySetReconstructable, or you've encountered an edge case or a bug that we need to investigate further.

@nagarjunaa
Copy link
Author

https://s3.eu-central-1.amazonaws.com/ohif-viewer/JSON/MRStudy.json
unable to get 2DMPR, i tried other options to but not getting, if anyone got this please let me know.

@nagarjunaa
Copy link
Author

hi Danny,
could you please help why 2DMPR is missing, for this

https://viewer.ohif.org/viewer?url=https://s3.eu-central-1.amazonaws.com/ohif-viewer/JSON/MRStudy.json

@dannyrb
Copy link
Member

dannyrb commented Feb 24, 2020

Related: #1460

@stale
Copy link

stale bot commented Mar 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Mar 16, 2020
@dannyrb
Copy link
Member

dannyrb commented Mar 17, 2020

This should be resolved in #1500

@dannyrb dannyrb closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants