Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): Add additional tools #588

Merged
merged 2 commits into from Jul 8, 2019

Conversation

@evren217
Copy link
Collaborator

evren217 commented Jun 24, 2019

Regarding to this feature request, here is the tools to add for cornerstone viewport:

  • ROI Window
  • Probe
  • Ellipse
  • Rectangle
  • Invert
  • Rotate Right
  • Flip H
  • Flip V
  • Clear

Moved until the next PR:

  • Annotate
  • Crosshairs
  • Previous Display Set
  • Next Display Set
  • Play / Stop
  • Download (might be a separate issue/PR)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #588 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #588   +/-   ##
======================================
  Coverage    0.86%   0.86%           
======================================
  Files          63      63           
  Lines        1160    1160           
  Branches      163     163           
======================================
  Hits           10      10           
  Misses        989     989           
  Partials      161     161
Impacted Files Coverage Δ
src/connectedComponents/PluginSwitch.js 0% <ø> (ø) ⬆️
src/setupTools.js 0% <ø> (ø) ⬆️
src/connectedComponents/ToolbarRow.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac9048...00ef03e. Read the comment docs.

});

measurementsToRemove.forEach(measurementData => {
OHIF.measurements.MeasurementHandlers.onRemoved({

This comment has been minimized.

Copy link
@dannyrb

dannyrb Jun 25, 2019

Member

Does the MeasurementHandlers not already subscribe to cornerstone events? Why do we need to call this manually?

This comment has been minimized.

Copy link
@evren217

evren217 Jun 25, 2019

Author Collaborator

It somehow does not handle the removed event when a measurement is removed using cornerstone tool state directly, so measurements are not removed from the measurement table otherwise. Either, cornerstone does not trigger removed event or that does not handle the event, not sure. Feel free to investigate it and just update this code to remove measurements using cornerstone tool state here.

This comment has been minimized.

Copy link
@swederik

swederik Jul 4, 2019

Member

Yeah It does not trigger the event if you remove it from the toolState programmatically. You don't need an event if you just called the function. The events are triggered by the tool changes.

@evren217 evren217 referenced this pull request Jul 3, 2019
@swederik swederik force-pushed the feat-additional-tools branch from 42ab9cc to 6f7885e Jul 8, 2019
@swederik swederik marked this pull request as ready for review Jul 8, 2019
@swederik swederik force-pushed the feat-additional-tools branch from 6f7885e to 1a7d3b3 Jul 8, 2019
evren217 and others added 2 commits Jun 24, 2019
…w, Probe, Ellipse, Rectangle, Invert, Rotate Right, Flip H, Flip V, Clear
@swederik swederik force-pushed the feat-additional-tools branch from 1a7d3b3 to 00ef03e Jul 8, 2019
@swederik swederik merged commit ce1a62a into master Jul 8, 2019
3 checks passed
3 checks passed
ci/circleci: build_and_test Your tests passed on CircleCI!
Details
codecov/project 0.86% remains the same compared to 5ac9048
Details
netlify/ohif/deploy-preview Deploy preview ready!
Details
@swederik swederik deleted the feat-additional-tools branch Jul 8, 2019
@ohif-bot

This comment has been minimized.

Copy link
Member

ohif-bot commented Jul 8, 2019

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ohif-bot ohif-bot added the released label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.