Skip to content

perf: ⚡️ Improve performance of pixel scaling #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamesAPetts merged 4 commits into from
Oct 8, 2019
Merged

perf: ⚡️ Improve performance of pixel scaling #48

JamesAPetts merged 4 commits into from
Oct 8, 2019

Conversation

@JamesAPetts
Copy link
Member

@JamesAPetts JamesAPetts commented Oct 8, 2019

Performance improvements for #47.

@JamesAPetts
refactor: 💡 Combine rescale computation with slice insertion
0db3ca2 
Combine rescale computation with slice insertion into volume.

Closes: OHIF#41
@JamesAPetts
Removed unused typed array.
6624909
@JamesAPetts
Improve performance of pixel scaling.
5278ee6
@JamesAPetts
perf: ⚡️ Improve performance of pixel scaling
12f31c7 
Bind a scaling function that only takes the pixel value to speed up
computation of scaled pixel values.

Closes: OHIF#41
@JamesAPetts JamesAPetts requested a review from swederik October 8, 2019 10:46
@JamesAPetts JamesAPetts merged commit 6b921b5 into OHIF:master Oct 8, 2019
@ohif-bot
Copy link
Member

ohif-bot commented Oct 8, 2019

🎉 This PR is included in version 0.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swederik swederik Awaiting requested review from swederik

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesAPetts @ohif-bot