Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect-itype: add tests #979

Closed
wants to merge 1 commit into from
Closed

detect-itype: add tests #979

wants to merge 1 commit into from

Conversation

hsadia538
Copy link
Contributor

Previous PR #973

Redmine Ticket

Describe Changes:

  • Update Readme file
  • Update test.yaml to remove min-version
  • Update rules to generate alerts on all

@hsadia538 hsadia538 mentioned this pull request Oct 25, 2022
Closed
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 25, 2022
jufajardini
jufajardini approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks :)

jasonish
jasonish approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@inashivb inashivb self-assigned this Oct 28, 2022
@inashivb inashivb mentioned this pull request Oct 28, 2022
Merged
@jasonish jasonish mentioned this pull request Oct 28, 2022
Closed
@jasonish
Copy link
Member

Merged. Thanks!

@jasonish jasonish closed this Oct 28, 2022
@hsadia538 hsadia538 deleted the detect-itype-5590-v3 branch January 13, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@jufajardini jufajardini jufajardini approved these changes

Assignees

@inashivb inashivb

Labels
outreachy Contributions made by Outreachy applicants
Milestone
No milestone
4 participants
@hsadia538 @jasonish @jufajardini @inashivb