Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect-bytemath: add tests #994

Closed
wants to merge 1 commit into from
Closed

detect-bytemath: add tests #994

wants to merge 1 commit into from

Conversation

hsadia538
Copy link
Contributor

@hsadia538 hsadia538 commented Oct 31, 2022 •
edited

Previous PR: #992

Redmine issue 5589

Conversion:

detect-bytemath-03: DetectByteMathPacket01 from detect-bytemath.c
detect-bytemath-04: DetectByteMathPacket02 from detect-bytemath.c

Describe new changes:

  • Update directory name
  • Fix typo in README
  • Update test.yaml

@hsadia538 hsadia538 mentioned this pull request Oct 31, 2022
Closed
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 31, 2022
@jlucovsky
Copy link
Contributor

Looks good .... Please update this PR's description so the Redmine issue number is available, e.g,
Redmine issue 5589

jufajardini
jufajardini approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially after Jeff's comment :)

@jasonish
Copy link
Member

jasonish commented Dec 7, 2022

Merged. Thanks!

@jasonish jasonish closed this Dec 7, 2022
@hsadia538 hsadia538 deleted the detect-bytemath-5589-v2 branch January 13, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jufajardini jufajardini jufajardini approved these changes

Assignees
No one assigned
Labels
outreachy Contributions made by Outreachy applicants
Milestone
No milestone
4 participants
@hsadia538 @jlucovsky @jasonish @jufajardini