Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unixsock v2.4 #3199

Closed
wants to merge 2 commits into from
Closed

Unixsock v2.4 #3199

wants to merge 2 commits into from

Conversation

regit
Copy link
Contributor

@regit regit commented Jan 29, 2018

Update of #3196 fixing issue

Describe changes:

  • Fix python 3 compatibility
  • Send command from suricata in one send syscall

PRScript output (if applicable):

@regit
unix socket: protocol v0.2
971026c 
This patch updates the unix socket protocol. Messages send from
the server and the client have now a '\n' at the end. This allows
both sides to detect easily the end of a command.

As a side effect, this fixes the problem of long answer in
suricatasc. There is now a limit at the arbitrary value of 65536.

Backward compatility is preserved as a client with the older
version of the protocol can still connect to a Suricata with
version 2 of the protocol.
@regit
suricatasc: implement autoreconnect
aab1644 
Implement a basic autoreconnect support. It tries to reconnect once
when connection has been lost. If it fails, it discards the command
and try again to connect at next command.
@regit regit requested a review from a team as a code owner January 29, 2018 21:51
@victorjulien victorjulien mentioned this pull request Feb 1, 2018
Merged
@victorjulien
Copy link
Member

Merged in #3209, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@regit @victorjulien