output-json: add MAC addresses to EVE-JSON logs - v9 #4968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds MAC address output to the EVE-JSON format. We follow the remarks made in Redmine ticket OISF#962: for packets, log MAC src/dst as a scalar field in EVE; for flows, log MAC src/dst as lists in EVE. Field names are different between flow and packet context to avoid type confusion (src_mac vs. src_macs). Configuration approach and JSON representation is taken from previous GitHub PR OISF#2700.
|
New PR: #4975 |
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Sep 27, 2023
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Oct 2, 2023
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #4767
Link to redmine ticket: #962
Describe changes (to previous PR):
SC_ATOMIC_SUB.decoder.max_mac_addrs_srcanddecoder.max_mac_addrs_dst)Suricata-verify tests (OISF/suricata-verify#197) have also been adapted.