Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz dnp3 fixes v1 #5093

Closed
wants to merge 5 commits into from
Closed

Conversation

catenacyber
Copy link
Contributor

Does not proceed final chunk if we got an error previously
Flips the direction for last chunk as usual

Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3772
https://redmine.openinfosecfoundation.org/issues/3773
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22832

Describe changes:

So, this is a mix of DNP3 and fuzzing, and can be split between different Pull Requests

Should I make a S-V test for the probing parser ?

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

@catenacyber catenacyber requested a review from a team as a code owner June 23, 2020 07:09
@catenacyber
Copy link
Contributor Author

Follows #5084 by adding dnp3 fix

@jasonish
Copy link
Member

Should I make a S-V test for the probing parser ?

Yes, please. DNP3 lacks test coverage on imperfect input I believe.

@catenacyber
Copy link
Contributor Author

Yes, please. DNP3 lacks test coverage on imperfect input I believe.

OISF/suricata-verify#261

@catenacyber catenacyber mentioned this pull request Jun 30, 2020
@victorjulien victorjulien mentioned this pull request Jul 7, 2020
@victorjulien
Copy link
Member

Merged in #5139, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants