New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust: generic files definition #5513
Conversation
Issue: Optimization 3825 - filecontainer: add Files structure, to replace/unify SMBFiles and NFSFiles - smb/files: delete SMBFiles implementation - smb/smb: replace SMBFiles with Files - nfs/nfs: delete NFSFiles implementation, replace its former declarations with Files' ones
Hi, have checked the details for the failed checks on appveyor, but I'm not quite sure what's wrong on my side. Can you please help me understand what do I have to do here, or if there's something else in my code that may be causing this, and I wasn't able to realise? Thanks in advance! :) |
About appveyor: Doesn't seem like an issue on your end. :) |
Appveyor seems to be having issues today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also HTTP2 in addition to SMB and NFS which should be replaced
Yeah, I saw that in the original discussion, but since it was not listed in this issue, and since I'm still new to the project, I need some approvals before tackling that. Can it be done right now, in this very branch/issue? |
Yes it can be done in this issue. |
ok, thanks! will try to do another PR tomorrow evening, then. |
Replaced by: #5531 to implement changes requested by @catenacyber . |
Issue: Optimization 3825
and NFSFiles
declarations with Files' ones
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3825
Link to previous PR:
#5511
Describe changes:
PRScript output (if applicable):
#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: