Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix inherent to string #6516

Closed

Conversation

TheKharleeci
Copy link
Contributor

@TheKharleeci TheKharleeci commented Oct 23, 2021

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4618

This commit addresses rust "inherent_to_string" warnings.

Describe changes:

  • ntlmssp_records:-Add fix to inherent_to_string warning
  • Remove #!allow(clippy::inherent_to_string) clippy lint from rust/src/lib.rs

ticket: #4618

Previous PR: #6491

rust: remove [allow(clippy::inherent_to_string)]
@jufajardini
Copy link
Contributor

looks good to me :)

@jasonish
Copy link
Member

looks good to me :)

Me to.

@victorjulien
Copy link
Member

Same comment #6529 (comment) applies here.

@TheKharleeci TheKharleeci mentioned this pull request Oct 31, 2021
3 tasks
@TheKharleeci
Copy link
Contributor Author

Followed by: #6547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants