detect: introduce "like" ip-only signature type - v2 #7466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules that look like they should be IP-only but contain a negated rule address are now marked with an LIKE_IPONLY flag. This is so they are treated like IPONLY rules with respect to flow action, but don't interfere with other IPONLY processing like using the radix tree. Ticket: OISF#5361
Codecov Report
@@ Coverage Diff @@
## master #7466 +/- ##
==========================================
+ Coverage 75.85% 75.87% +0.01%
==========================================
Files 657 657
Lines 189465 189469 +4
==========================================
+ Hits 143713 143753 +40
+ Misses 45752 45716 -36
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
"Attempt to make cocci happy, but still unsuccessful." -> it passed actually, the failure was in MacOS but was a flaky test |
victorjulien
approved these changes
Jun 2, 2022
|
ERROR: ERROR: QA failed on tlpw1_files_sha256. ERROR: QA failed on tlpr1_alerts_cmp. Pipeline 7639 |
Merged
|
Merged in #7467, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules that look like they should be IP-only but contain a negated rule
address are now marked with an LIKE_IPONLY flag. This is so they are
treated like IPONLY rules with respect to flow action, but don't
interfere with other IPONLY processing like using the radix tree.
Ticket: https://redmine.openinfosecfoundation.org/issues/5361
Previous PR:
Changes from last PR:
suricata-verify-pr: 824