flow/icmpv4: fix vlan.use-for-tracking #7861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ICMPv4 error messages the vlan ids were always considered, even if the 'vlan.use-for-tracking' option was disabled. Ticket: OISF#5330
Codecov Report
@@ Coverage Diff @@
## master #7861 +/- ##
==========================================
+ Coverage 75.99% 76.11% +0.12%
==========================================
Files 665 666 +1
Lines 185963 185992 +29
==========================================
+ Hits 141327 141575 +248
+ Misses 44636 44417 -219
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Waits for CI fix cf #7871 |
|
Merged in #7884, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5330
Describe changes:
vlan.use-for-trackingalso for ICMPv4 flowsThat is use util function
CmpVlanIdsas is done in other casesReplaces #7859 with reworded commit
libhtp-pr: 366