Template is re-applied before sending #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template is re-applied before sending to regenerate time-based text
|
Shouldn't that also apply to %d? |
|
Or is that already implied anyway? (I only looked at the patch so far, not the full context.) |
|
It applies to all of them, it just runs the applyTemplate() func before sending. Many wont change in a session, but %t is mostly the reason i did this. I send in a net and I'll add an image 5 minutes before my turn to transmit, so the template with timestamp in it was always off. I've been running with this in for about a year. |
|
Sounds useful to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template is re-applied before sending to regenerate %t macro and ensure any changes since loading the image are represented.