Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error: cannot convert ‘bool’ to ‘SVG::DrawElement*’ in return #575

Closed
onny opened this issue May 29, 2019 · 4 comments
Closed
Assignees
Labels
confirmed-bug Issues with confirmed bugs fixed Issues that fixed and released

Comments

@onny
Copy link

onny commented May 29, 2019

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
With gcc 8.3 on Archlinux x64 i get following error, trying to compile DocumentServer 5.3:

../../../raster/Metafile/svg/SVGFramework.h: In member function ‘SVG::DrawElement* SVG::Parser::Create(XmlUtils::CXmlNode&, bool)’:
../../../raster/Metafile/svg/SVGFramework.h:5939:13: error: cannot convert ‘bool’ to ‘SVG::DrawElement*’ in return                                                                                          
      return false; 
[...]
make[1]: *** [Makefile:2216: ../core_build/linux_64/release/obj/SVGFramework.o] Error 1
make[1]: Leaving directory '/home/onny/projects/onlyoffice-documentserver/src/DocumentServer-ONLYOFFICE-DocumentServer-5.3.0/core/DesktopEditor/graphics/pro/graphics.build'
make: *** [Makefile:278: build/lib/linux_64/libgraphics.so*] Error 2

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

  # Download & build third party modules 
  cd core/Common/3dParty
  ./make.sh

  # Building core
  cd ../..
  make

What is the expected behavior?
Compilation should run fine

Did this work in previous versions of DocumentServer?
Yes

@ShockwaveNN ShockwaveNN added the confirmed-bug Issues with confirmed bugs label May 29, 2019
@ShockwaveNN
Copy link
Contributor

@onny Hi, could you try to build with this fix?
ONLYOFFICE/core@d2efc3f

@onny
Copy link
Author

onny commented May 29, 2019

Yep that fixed the issue. Thank you :)

@onny onny closed this as completed May 29, 2019
@ShockwaveNN ShockwaveNN reopened this May 30, 2019
@ShockwaveNN
Copy link
Contributor

@onny I leave issue opened until we release fix as master

@ShockwaveNN ShockwaveNN added the fixed Issues that fixed and released label May 30, 2019
@ShockwaveNN
Copy link
Contributor

DocumentServer 5.3.1 is released and this problem should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs fixed Issues that fixed and released
Projects
None yet
Development

No branches or pull requests

3 participants