Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Translation for "textPoweredBy" #142

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@EricChen1688
Copy link
Contributor

commented Nov 19, 2018

No description provided.

@agolybev agolybev requested a review from alexandervnuchkov Nov 28, 2018

@agolybev agolybev changed the base branch from master to hotfix/v5.2.4 Nov 28, 2018

@alexandervnuchkov

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

The proposed translation means "Technical support" in English. The meaning of the original phrase is different. I'm not sure about the correctness of the previous translation, but Google translate says it is translated as "Powered by". I would like to hear the reason of the translation change from @EricChen1688 before we use this translation.

@EricChen1688

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

The previous translation "电供应" means "Electricity supply by" in Chinese , the translation I proposed is the correct/common translation in Chinese ,see in youdao.com @alexandervnuchkov

@agolybev agolybev merged commit deb8ff0 into ONLYOFFICE:hotfix/v5.2.4 Dec 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@agolybev

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

@EricChen1688, @alexandervnuchkov could you change the same resource in the web-app-pro repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.