New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv16fp #127

merged 20 commits into from Jan 22, 2019


None yet
4 participants
Copy link

lubatang commented Jan 22, 2019

Add NvDla fp16 backend.

champyen and others added some commits Nov 16, 2018

Move files to up-level folder.
Help users to clone the NVDLA backend project like that:
cd ${ONNC}/lib/Target
git clone NVDLA
1. add concat operation for GoogleNet
2. fix reshape cases
3. fix wrong pointer of LRN lut parameter filling
4. fix WEIGHT banks calculation
Refine header.
Only system library can use postfix `_` in header.
Remove void parameter.
Because C++ member function hides a `this` parameter,  declaration of a `void`
parameter confuses code readers. We only allow non-member functions to
use `void` parameter (because there is no implicit `this` parameter).
Move implementation to .cpp.
Header is used to tell the other developers what they should know.
Hide what they don't need to know in the .cpp file.
Keep header simple.
Make getReducedBank() member function constant.
Constant object only can use constant member functions.
Import NVDLA.
git-subtree-dir: lib/Target/NVDLA
git-subtree-mainline: 0af0d15
git-subtree-split: a5d97e8
Rename folder NVDLA -> NvDla.
Follow the naming convention of NvDla SW.
rename Nvdla -> NvDla.
This is used to follow NvDla SW naming convention.
Po Yen Chen
Remove pointer memter `m_pMeta` from `CodeEmitVisitor`
For never bind to other and non-owning semantics, use
reference as data member
Put date members in private field.
No outsiders shall access it.

@lubatang lubatang requested a review from poyenc Jan 22, 2019

@poyenc poyenc merged commit 93cbca8 into master Jan 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment