-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triangular Face element #78
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 87.16% 87.21% +0.05%
==========================================
Files 25 26 +1
Lines 553 563 +10
==========================================
+ Hits 482 491 +9
- Misses 71 72 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vamo arrucaaaaa
end | ||
|
||
"Returns a `Vector` of`Node`s for the `TriangularFace` `tf`." | ||
nodes(tf::TriangularFace) = [tf.n₁, tf.n₂, tf.n₃] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this allocates; you may want to revisit later, storing an SVector directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I also considered to store the nodes of the elements into a Vector instead of separated files:
struct TriangularFace{dim,N<:AbstractNode{dim},T<:Real} <: AbstractFace{dim,T}
nodes::SVector{N}
label::Symbol
function TriangularFace(n₁::N, n₂::N, n₃::N, label=:no_labelled_face) where
{dim,T<:Real,N<:AbstractNode{dim,T}}
new{dim,N,T}(SVector(n₁, n₂, n₃), Symbol(label))
end
end
"Returns the nodes for the `TriangularFace` `tf`."
nodes(tf::TriangularFace) = [tf.n₁, tf.n₂, tf.n₃]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open this in this issue #80
Addressing #77
In this PR a new
AbstractFace
abstract type is introduced, this abstract types is useful for processing boundary conditions. In particular, this new leaf is implemented:Also
StructuralBoundaryConditions
struct can now include faces boundary conditions.