Convert masthead logos to inline #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1366 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 33 33
Lines 1529 1529
=======================================
Hits 1431 1431
Misses 98 98 Continue to review full report at Codecov.
|
boxadesign
reviewed
Feb 11, 2021
…tal/design-system into convert-masthead-logos-to-inline
rmccar
force-pushed
the
convert-masthead-logos-to-inline
branch
from
4c10392
to
ad04bb2
Compare
|
Footer icon missing |
|
Can we get the focus states tighter around the logos?
|
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
rmccar
force-pushed
the
convert-masthead-logos-to-inline
branch
from
e175ffe
to
8c8a127
Compare
rmccar
force-pushed
the
convert-masthead-logos-to-inline
branch
from
9e3d5fd
to
fe80482
Compare
jrbarnes9
reviewed
May 13, 2021
src/components/header/index.njk
Outdated
Comment on lines
28
to
30
| The [ghost button](/components/button/#header-style) in the header moves to the [footer](/components/footer) when the page width is under the medium breakpoint (less than 740px). | ||
|
|
||
| The external header with language switch and save button, should be used across public facing services. |
There was a problem hiding this comment.
Flip the order of these paragraphs
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
jrbarnes9
approved these changes
May 13, 2021
boxadesign
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This PR converts the masthead logos to inline svgs. This allows us to set the focus colour of the logo in css.
Also fixes an issue with the focus state on the nisra logo being too small and adds the
customHeaderLogoparam to the docs.How to review
customHeaderLogois added to the docs