Prevent IR request link from appearing on all interstitial pages #310
Conversation
…aire-runner into fix-request-link
app/views/handlers/content.py
Outdated
| "show_individual_response_link": show_individual_response_link( | ||
| self._current_location, self._schema | ||
| ) |
There was a problem hiding this comment.
Currently there's a lot of duplication here.
I would expect all the templates that show the IR link (hub/interstitial) to use the same variable for determining visibility of the link.
There was a problem hiding this comment.
Duplication removed, extra variable gone. Just need to add tests now👍.
Co-authored-by: Ian Wootten <hi@niftydigits.com>
|
|
||
| @staticmethod | ||
| def show_individual_response(location, schema): | ||
| section = schema.json.get("individual_response", {}).get( |
There was a problem hiding this comment.
I think you've misunderstood my original comment here - the first line here that returns the section_id should be a separate method I think and shouldn't be static when part of questionnaire_schema as schema is an instance of it. I think this method name should probably change too as it doesn't describe the check. Something like is_individual_response_interstitial makes more sense.
There was a problem hiding this comment.
For this method, is_first_block_in_individual_response is probably more appropriate since it being an interstitial is irrelevant?
There was a problem hiding this comment.
@iwootten that first line is now a method in Questionnaire Schema class. Thanks!
| def get_individual_response_individual_section_id(self): | ||
| return self._questionnaire_json.get("individual_response", {}).get( | ||
| "individual_section_id" | ||
| ) |
There was a problem hiding this comment.
Would be nice to group this with the other IR methods in this class for clarity.
There was a problem hiding this comment.
Moved it to ir group now.
Co-authored-by: Mebin Abraham <35296336+MebinAbraham@users.noreply.github.com>
What is the context of this PR?
This change prevents individual response link from appearing on all interstitial pages. Trello card.
How to review
Manually run
test_individual_responseschema to check if this change works, use test_individual_response.py integration test for automated testing.Checklist