Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable translation of Detail_Answer #23

Merged
merged 1 commit into from Dec 7, 2018
Merged

Enable translation of Detail_Answer #23

merged 1 commit into from Dec 7, 2018

Conversation

dwyeradam
Copy link
Contributor

@dwyeradam dwyeradam commented Nov 29, 2018 •
edited

child_answers have been replaced with detail_answers within the option itself. Therefore the translation scripts need to be able to process these detail answers when getting options.

From Runner PR

MebinAbraham
MebinAbraham approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this PR does what its meant to do.

@dwyeradam dwyeradam force-pushed the eq-2312-multiple-other-write-in-fields branch from 17f19bb to c04919d Compare December 7, 2018 10:32
@bitdivision bitdivision merged commit e133743 into master Dec 7, 2018
@bitdivision bitdivision deleted the eq-2312-multiple-other-write-in-fields branch December 7, 2018 11:49
iwootten pushed a commit that referenced this pull request Feb 21, 2019
@dwyeradam @iwootten
# This is a combination of 45 commits.
9b6fff1 
# This is the 1st commit message:

Add support for translation of schemas using Pot Files

# This is the commit message #2:

Fix broken tests

# This is the commit message #3:

Correct spacing

# This is the commit message #4:

Remove test output from repo

# This is the commit message #5:

Label schema appropriately

# This is the commit message #6:

Tidy up naming

# This is the commit message #7:

Move main method into extractor class

# This is the commit message #8:

Use static methods where appropriate

# This is the commit message #9:

Add csv tranform test

# This is the commit message #10:

Use argparse throughout

# This is the commit message #11:

Correct spacing

# This is the commit message #12:

Remove common methods and put them in one place

# This is the commit message #13:

Remove common methods and put them in one place

# This is the commit message #14:

Correct output path

# This is the commit message #15:

Remove output from test

# This is the commit message #16:

Create paths when they don't exist

# This is the commit message #17:

Move translator class into separate file

# This is the commit message #18:

Correct Spacing

# This is the commit message #19:

Remove ability to transform to xls

# This is the commit message #20:

Remove unused import

# This is the commit message #21:

Remove unneccessary translation object call

# This is the commit message #22:

Add missing method

# This is the commit message #23:

Correct spacing

# This is the commit message #24:

Remove all xls transforms from repo

# This is the commit message #25:

Add newline to header to be importable

# This is the commit message #26:

Remove all shell scripts and replace with python

# This is the commit message #27:

Workaround for travis numpy weirdness

# This is the commit message #28:

Block empty legal_basis

# This is the commit message #29:

Block empty legal_basis

# This is the commit message #30:

Block missin legal basis

# This is the commit message #31:

Remove csv conversion from extractor

# This is the commit message #32:

Update readme

# This is the commit message #33:

Remove TODO's

# This is the commit message #34:

Only allow po files

# This is the commit message #35:

Remove condition

# This is the commit message #36:

Only ask for output path on save

# This is the commit message #37:

Remove context to meet Adam's original method calls

# This is the commit message #38:

Correct argument description:

# This is the commit message #39:

Use cwd for source of parent

# This is the commit message #40:

Remove '_translate_' from naming

# This is the commit message #41:

Remove duplicate file

# This is the commit message #42:

Don't attempt to translate if template but no schema

# This is the commit message #43:

Add better description

# This is the commit message #44:

Address comment

# This is the commit message #45:

Remove context from everything in extract template except answer options. Only print answer id's as template comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitdivision bitdivision bitdivision approved these changes

@MebinAbraham MebinAbraham MebinAbraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dwyeradam @bitdivision @MebinAbraham