Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interfaces IServiceMessageContext, IEncodeableFactory #1407

Merged
merged 6 commits into from Jun 11, 2021
Merged

Add interfaces IServiceMessageContext, IEncodeableFactory #1407

merged 6 commits into from Jun 11, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented May 20, 2021 •
edited

  • improve useability/testability of encoders/decoders
  • lets wait until 366 is stabilized, as this is a breaking change and needs a version bump to 367

@mregen mregen marked this pull request as draft May 21, 2021 04:49
@mregen mregen marked this pull request as ready for review June 9, 2021 17:21
@mregen
Copy link
Contributor Author

mregen commented Jun 11, 2021

@AlinMoldovean ready, please review.

AlinMoldovean
AlinMoldovean approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@AlinMoldovean AlinMoldovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to increase the version to 1.4.367 since we add breaking changes.

@mregen mregen merged commit 24f90c4 into OPCFoundation:master Jun 11, 2021
@mregen mregen deleted the proto_iservicemessagecontext branch June 11, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlinMoldovean AlinMoldovean AlinMoldovean approved these changes

@koepalex koepalex Awaiting requested review from koepalex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mregen @AlinMoldovean