Revamp Build System for Boost #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements the approach of (e.g.,) ax_boost_system.m4, but may lose some of the initial refinements. In that case, we will have to refine this code.
This enables explicitly encoding the directory, e.g., in the OPM-Core run-path. This, in turn, reduces the burden on library clients that would otherwise have to satisfy library link requirements in addition to any other link requirements they might have.
Specifically, use the OPM_BOOST_LIBDIR variable created in commit 5c97e512 and Libtool's "-R" link-time switch to encode the library location within OPM-Core's run-path. This simplifies using the library, because the onus of satisfying the library's link-time requirements is removed from the client. A second refinement puts the additional link-requirements (i.e., "-l" and "-L" options) within the *_LIBADD primary. This moves the libraries from the middle to the end of the link statement. middle.
Specifically, commit ff4f709e made the support for transitively conveying interlibrary dependencies onto clients of OPM-Core more robust. As a consequence, we no longer need to explicitly link in the Boost.System or Boost.Filesystem libraries to use the software contained therein.
|
Builds with no problems for me, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change encodes the Boost library location into the active run-path of
libopmcore.so.0.0.0such that Boost is automatically conveyed on to clients of the OPM-Core library. This removes some of the inconvenience associated to using OPM-Core in other projects.The change also splits the
libopmcore.lalink statement in such a way that all libraries are put at the end of the link line rather than the beginning. While the outcome is typically unchanged in the case of GNU's linker, this is the more portable definition.