Skip to content

Conversation

@bska
Copy link
Member

@bska bska commented May 12, 2025

Following PR OPM/opm-common#4439, we can activate most of the aspects of the model in PR OPM/opm-tests#1299.

@bska bska added the manual:irrelevant This PR is a minor fix and should not appear in the manual label May 12, 2025
@bska
Copy link
Member Author

bska commented May 12, 2025

I'm creating this PR in draft mode because I want to run a few checks on the CI system before enabling the regression test.

@bska
Copy link
Member Author

bska commented May 12, 2025

jenkins build this please

@bska bska force-pushed the uda-compat-rst branch 11 times, most recently from 5aebc10 to 3b49bf2 Compare May 15, 2025 16:09
@bska
Copy link
Member Author

bska commented May 16, 2025

I think I'm ready to introduce this regression test now so I'm marking the PR as "ready for review". We will need to calculate reference solutions before merging the test.

@bska bska marked this pull request as ready for review May 16, 2025 08:40
Copy link
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cosmetic

Following PR OPM/opm-common#4439, we can activate most of the
aspects of the model in PR OPM/opm-tests#1299.
@bska bska force-pushed the uda-compat-rst branch from 3b49bf2 to 360c508 Compare May 16, 2025 09:11
@bska
Copy link
Member Author

bska commented May 16, 2025

jenkins build this update_data please

jenkins4opm pushed a commit to jenkins4opm/opm-tests that referenced this pull request May 16, 2025
Reason: PR OPM/opm-simulators#6265

opm-common     = c859442dca801b17ee73d433b7d6bc2b88361d5a
opm-grid       = 1affdfaf96779f196a27529cfe1839a3ea6ca49c
opm-simulators = 1f8690458ff282dfae4f265d52eb0bf94c0b4fa2

### Changed Tests ###

  * 6_uda_model5_stdw
  * 6_uda_model5_stdw(restart)
@bska
Copy link
Member Author

bska commented May 16, 2025

jenkins build this opm-tests=1341 please

bska added a commit to OPM/opm-tests that referenced this pull request May 16, 2025
@bska
Copy link
Member Author

bska commented May 16, 2025

PR approved, build check is green, and the new reference solutions have been installed on the CI system. I'll merge into master.

@bska bska merged commit 4f3175a into OPM:master May 16, 2025
2 checks passed
@bska bska deleted the uda-compat-rst branch May 16, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants