Skip to content

Fixes for gliftopt item 3 maximum gas+alq #6620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
totto82 merged 8 commits into from
Dec 3, 2025
+610 −432
Merged

Fixes for gliftopt item 3 maximum gas+alq #6620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6cf86b3
Fixes for gliftopt item 3 maximum gas+alq
Nov 19, 2025
abab405
Limit the rates with targets in consitent way
Nov 19, 2025
0a7501d
update well potential for all well after gaslift
Nov 24, 2025
59ac8cf
Enhance glift1 test to actually test gaslift optimization
Nov 24, 2025
f9008d0
Add a test for GLIFTOPT in glift1 to test interaction with group control
Nov 25, 2025
39db862
Store and update well potentials during gaslift optimization
Nov 28, 2025
ad6bc9a
Revert change where only alq_is_limited is true when increase is true
Dec 2, 2025
b21ac4f
Proper fix for alq_is_limited
Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions opm/simulators/wells/BlackoilWellModelGasLift_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,16 +248,6 @@ gasLiftOptimizationStage1(const Simulator& simulator,
group_alq_rates[j]);
}
}
if constexpr (glift_debug) {
int counter = 0;
if (comm.rank() == i) {
counter = wellState.gliftGetDebugCounter();
}
counter = comm.sum(counter);
if (comm.rank() != i) {
wellState.gliftSetDebugCounter(counter);
}
}
}
}
}
Expand Down
23 changes: 20 additions & 3 deletions opm/simulators/wells/GasLiftGroupInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,17 +547,24 @@ getProducerWellRates_(const Well* well, int well_index)
Scalar water_rate = water_pot;
Scalar gas_rate = gas_pot;

// The well rates are potentially limited by the targets
// The other phases are scaled accordingly. i.e. we assume the phase fractions are the same
// This is not 100% true but the best we can do without solving the well equation
if (controls.hasControl(Well::ProducerCMode::ORAT) && oil_rate > static_cast<Scalar>(controls.oil_rate)) {
water_rate *= (static_cast<Scalar>(controls.oil_rate) / oil_rate);
gas_rate *= (static_cast<Scalar>(controls.oil_rate) / oil_rate);
Copy link
Contributor

@hakonhagland hakonhagland Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It seems unlikely that oil_rate will be zero since it is known to be greater than controls.oil_rate, but if controls.oil_rate ~= 0 it could in theory become very small. Should we check for this before scaling? 2) We could also add a comment about why this scaling is needed.

Copy link
Member Author

@totto82 totto82 Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since oil_rate > controls.oil_rate >= 0 I think controls.oil_rate / oil_rate should be safe.

oil_rate = static_cast<Scalar>(controls.oil_rate);
}

if (controls.hasControl(Well::ProducerCMode::GRAT)) {
gas_rate = std::min(static_cast<Scalar>(controls.gas_rate), gas_rate);
if (controls.hasControl(Well::ProducerCMode::GRAT) && gas_rate > static_cast<Scalar>(controls.gas_rate)) {
water_rate *= (static_cast<Scalar>(controls.gas_rate) / gas_rate);
oil_rate *= (static_cast<Scalar>(controls.gas_rate) / gas_rate);
gas_rate = static_cast<Scalar>(controls.gas_rate);
}

if (controls.hasControl(Well::ProducerCMode::WRAT) && water_rate > static_cast<Scalar>(controls.water_rate)) {
oil_rate *= (static_cast<Scalar>(controls.water_rate) / water_rate);
gas_rate *= (static_cast<Scalar>(controls.water_rate) / water_rate);
water_rate = static_cast<Scalar>(controls.water_rate);
}
if (controls.hasControl(Well::ProducerCMode::LRAT)) {
Expand All @@ -566,6 +573,7 @@ getProducerWellRates_(const Well* well, int well_index)
if (liquid_rate > liquid_rate_lim) {
water_rate = water_rate / liquid_rate * liquid_rate_lim;
oil_rate = oil_rate / liquid_rate * liquid_rate_lim;
gas_rate = gas_rate / liquid_rate * liquid_rate_lim;
}
}

Expand Down Expand Up @@ -668,14 +676,22 @@ initializeGroupRatesRecursive_(const Group& group)
group.name(), oil_rate, gas_rate, water_rate, alq);
}

// The group rates are potentially limited by the group targets
// The other phases are scaled accordingly. i.e. we assume the phase fractions are the same
// This is not 100% true but the best we can do without solving the well equation
if (oil_target && oil_rate > *oil_target) {
water_rate *= (*oil_target/oil_rate);
gas_rate *= (*oil_target/oil_rate);
oil_rate = *oil_target;
}
if (gas_target && gas_rate > *gas_target)
if (gas_target && gas_rate > *gas_target) {
water_rate *= (*gas_target/gas_rate);
oil_rate *= (*gas_target/gas_rate);
gas_rate = *gas_target;
}
if (water_target && water_rate > *water_target) {
oil_rate *= (*water_target/water_rate);
gas_rate *= (*water_target/water_rate);
water_rate = *water_target;
}
if (liquid_target) {
Expand All @@ -684,6 +700,7 @@ initializeGroupRatesRecursive_(const Group& group)
if (liquid_rate > liquid_rate_limited) {
oil_rate = oil_rate / liquid_rate * liquid_rate_limited;
water_rate = water_rate / liquid_rate * liquid_rate_limited;
gas_rate = gas_rate / liquid_rate * liquid_rate_limited;
}
}
}
Expand Down
Loading